Skip to content

Adding support for locating functions within nested types and nested namespaces from referenced assemblies#2054

Merged
kshyju merged 2 commits intomainfrom
shkr/2049
Nov 10, 2023
Merged

Adding support for locating functions within nested types and nested namespaces from referenced assemblies#2054
kshyju merged 2 commits intomainfrom
shkr/2049

Conversation

@kshyju
Copy link
Copy Markdown
Member

@kshyju kshyju commented Nov 10, 2023

Adding support for locating functions within nested types and nested namespaces from referenced assemblies.

Fixes #2052

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju requested review from brettsam, fabiocav, jviau and satvu and removed request for satvu November 10, 2023 21:35
@kshyju kshyju merged commit 172ddf5 into main Nov 10, 2023
@kshyju kshyju deleted the shkr/2049 branch November 10, 2023 23:39
@fabiocav
Copy link
Copy Markdown
Member

Had a chat with @kshyju about using a symbol visitor for this instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle nested namespaces when probing for functions from referenced assemblies

4 participants